This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
ipse gerrit-no-reply at lists.osmocom.orgipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15793 ) Change subject: vty: Simplify filler burst settings and improve help and readability. ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c File CommonLibs/trx_vty.c: https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c@a197 PS1, Line 197: test rach-delay <0-68> > I understand that these commands are kind of special, and not everybody uses them, but anyway we sho […] These functions are used for special types of testing and looking at how they are implemented, I don't think anyone really used them. And given that the logic of the functions has changed, I frankly don't see a justification for the effort to re-implement them and keep unused code in the source tree. https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c@a308 PS1, Line 308: trx->cfg.filler = FILLER_EDGE_RAND; > Makes sense to send this fix as a separate patch. I don't think it's really necessary but I've split the patch anyway. https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c@63 PS1, Line 63: gmsk-rand > Just an idea, not a merge blocker: GMSK is used for Access Bursts too. This may be a bit confusing. […] Yes, good point, I'll change the names to be more consistent. https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c@360 PS1, Line 360: rach > In general, this parameter has nothing to do with Random Access Channel. […] Yes, I was also thinking of that. I'll change the name. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I752eb2c1162d084e8769181f2fcd6c0877663448 Gerrit-Change-Number: 15793 Gerrit-PatchSet: 3 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Tue, 15 Oct 2019 11:25:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191015/6a8e2b99/attachment.htm>