Change in libosmocore[master]: tdef: Return correct snprintf value for osmo_tdef_range_str_buf()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Oct 11 15:05:44 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15779 )


Change subject: tdef: Return correct snprintf value for osmo_tdef_range_str_buf()
......................................................................

tdef: Return correct snprintf value for osmo_tdef_range_str_buf()

len provides extra information in the case the buffer was too small,
because it tells the caller "the number of characters (excluding the
terminating null byte) which would have been written to the final
string if enough space had been available" (man
snprintf).

Change-Id: Icafe559e19a92e2ae72fdd0dd2d9a394b1eda878
---
M src/tdef.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/79/15779/1

diff --git a/src/tdef.c b/src/tdef.c
index 94d987f..7a709b4 100644
--- a/src/tdef.c
+++ b/src/tdef.c
@@ -275,7 +275,7 @@
 	if (ret < 0)
 		return ret;
 	OSMO_SNPRINTF_RET(ret, rem, offset, len);
-	return ret;
+	return len;
 }
 
 /*! Using osmo_tdef for osmo_fsm_inst: find a given state's osmo_tdef_state_timeout entry.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15779
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icafe559e19a92e2ae72fdd0dd2d9a394b1eda878
Gerrit-Change-Number: 15779
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191011/849cc1cb/attachment.htm>


More information about the gerrit-log mailing list