This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15757 ) Change subject: scheduler_trx: use gsm0502_fn_remap() to calculate frame number ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/15757/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/15757/1/src/osmo-bts-trx/scheduler_trx.c@1230 PS1, Line 1230: FN_REMAP_FACCH_F You can't be sure at this point as you don't know whether it's FACCH or speech. https://gerrit.osmocom.org/#/c/15757/1/src/osmo-bts-trx/scheduler_trx.c@1318 PS1, Line 1318: FN_REMAP_FACCH_F That's actually not FACCH. https://gerrit.osmocom.org/#/c/15757/1/src/osmo-bts-trx/scheduler_trx.c@1442 PS1, Line 1442: FN_REMAP_TCH_H0 Same here, what if the received frame is FACCH/H? https://gerrit.osmocom.org/#/c/15757/1/src/osmo-bts-trx/scheduler_trx.c@1473 PS1, Line 1473: FN_REMAP_FACCH_H0 Can be simplified: FN_REMAP_FACCH_H0 + lchan->nr. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37601ddd85e4287dd9e41ad4a8cb7d314de1a83d Gerrit-Change-Number: 15757 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 10 Oct 2019 15:52:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191010/aed51e5c/attachment.htm>