Change in ...osmo-bts[master]: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Oct 9 16:45:48 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15714 )

Change subject: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U
......................................................................

L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

Change-Id: Id69010ffa8c697e8c01bbb21509253c330f95343
---
M src/common/l1sap.c
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 0696fab..7d403f0 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -333,13 +333,6 @@
 	if (L1SAP_IS_PTCCH(fn)) {
 		*chan_type = GSMTAP_CHANNEL_PTCCH;
 		*ss = L1SAP_FN2PTCCHBLOCK(fn);
-		if (l1sap->oph.primitive == PRIM_OP_INDICATION) {
-			OSMO_ASSERT(len > 0);
-			if ((*data[0]) == 7)
-				return -EINVAL;
-			(*data)++;
-			(*len)--;
-		}
 	} else
 		*chan_type = GSMTAP_CHANNEL_PACCH;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15714
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id69010ffa8c697e8c01bbb21509253c330f95343
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191009/de911bf5/attachment.htm>


More information about the gerrit-log mailing list