This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15678 ) Change subject: PCUIF_RAW_Components.ttcn: ClckGen_CT: fix PTCCH event handling ...................................................................... PCUIF_RAW_Components.ttcn: ClckGen_CT: fix PTCCH event handling Both TDMA_EV_PTCCH_DL_BLOCK and TDMA_EV_PTCCH_UL_BURST events may happen together during the same TDMA frame (fn % 104 == 90). We shall not skip TDMA_EV_PTCCH_UL_BURST. Let's fix this. Change-Id: Ifc66d5d1c5f9eaa7bed6882105298c45257ebef0 --- M pcu/PCUIF_RAW_Components.ttcn 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pcu/PCUIF_RAW_Components.ttcn b/pcu/PCUIF_RAW_Components.ttcn index 7feeca2..465e398 100644 --- a/pcu/PCUIF_RAW_Components.ttcn +++ b/pcu/PCUIF_RAW_Components.ttcn @@ -148,11 +148,12 @@ } else if (fn13 == 3 or fn13 == 7 or fn13 == 11) { /* 4/4 bursts of a PDTCH block on both Uplink and Downlink */ CLCK.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PDTCH_BLOCK_END, fn)); - } else if (fn104 == 90) { - /* 4/4 bursts of a PTCCH (Timing Advance Control) block on Downlink */ - CLCK.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PTCCH_DL_BLOCK, fn)); } else if (fn52 == 12 or fn52 == 38) { - /* One Access Burst on PTCCH/U */ + /* 4/4 bursts of a PTCCH (Timing Advance Control) block on Downlink */ + if (fn104 == 90) { + CLCK.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PTCCH_DL_BLOCK, fn)); + } + /* One Access Burst on PTCCH/U (goes 3 time-slots after PTCCH/D) */ CLCK.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PTCCH_UL_BURST, fn)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifc66d5d1c5f9eaa7bed6882105298c45257ebef0 Gerrit-Change-Number: 15678 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191009/87fda9d2/attachment.htm>