This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15681 ) Change subject: pcu: Introduce test TC_mo_ping_pong ...................................................................... Patch Set 6: Code-Review+1 (1 comment) It seems to me that this case was implemented looking at the current behaviour of OsmoPCU, which may be incorrect (remember the situation with PTCCH/U, when everybody wrongly expected data blocks on it). Could you please add the spec. references where the process of Downlink TBF establishment is described? At least where they state that Immediate Assignment (assigning a Downlink TBF) shall be sent on PCH (and not on AGCH). The code itself looks good to me. https://gerrit.osmocom.org/#/c/15681/6/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/#/c/15681/6/pcu/PCU_Tests_RAW.ttcn@625 PS6, Line 625: data LOL, I just checked the source code of OsmoPCU, and, as it turns out, replying the whole payload from DATA.req is only needed to parse TLLI from it. Who ever thought it's a good idea... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3be5123ff5294e5851652ec14d54589442082b28 Gerrit-Change-Number: 15681 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 09 Oct 2019 15:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191009/dd0cf812/attachment.htm>