Change in ...libosmocore[master]: logging: Introduce mutex API to manage log_target in multi-thread envs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Oct 9 12:18:57 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15560 )

Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/15560/6/src/vty/logging_vty.c 
File src/vty/logging_vty.c:

https://gerrit.osmocom.org/#/c/15560/6/src/vty/logging_vty.c@122 
PS6, Line 122: 
> How about placing these two macros in a header file, and using them in gprs_bssgp_vty. […]
I'd prefer not having those defines end up in a header file and eventually being used as a public API. This is a useful in-place macro since 99% of all-ever osmo_log_target related functions are placed in this file.

A few more are in logging.c which anyway acquire the lock in a different way.

Then, other 2 users in libosmocore (and other libosmocore app users) mainly need to only protect the filter functions, and it's a low amount of them, so it's fine doing what this macro does here manually.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15560
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id7711893b34263baacac6caf4d489467053131bb
Gerrit-Change-Number: 15560
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Oct 2019 12:18:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191009/5ce825ec/attachment.htm>


More information about the gerrit-log mailing list