This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15702 ) Change subject: bts-trx: Log TRXC and TRXD socket recv()/send() failures ...................................................................... Patch Set 1: Code-Review+1 (5 comments) Checking rc of send() - cool! Coverity was complaining about that for a long time. I don't like using goto without the real need for that, otherwise I would CR+2. Also, I would prefer strerror(). https://gerrit.osmocom.org/#/c/15702/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/15702/1/src/osmo-bts-trx/trx_if.c@104 PS1, Line 104: strerror_r This is a single thread application, so calling strerror() would be enough. https://gerrit.osmocom.org/#/c/15702/1/src/osmo-bts-trx/trx_if.c@165 PS1, Line 165: strerror_r Same. https://gerrit.osmocom.org/#/c/15702/1/src/osmo-bts-trx/trx_if.c@992 PS1, Line 992: strerror_r Same. https://gerrit.osmocom.org/#/c/15702/1/src/osmo-bts-trx/trx_if.c@1111 PS1, Line 1111: goto Any reason to use goto here? This is the only failure branch right now, and I don't think there will be more calls to send() in this function. https://gerrit.osmocom.org/#/c/15702/1/src/osmo-bts-trx/trx_if.c@1118 PS1, Line 1118: strerror_r Same. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic3e41d82b43459495d45873d612a3bd349ac174a Gerrit-Change-Number: 15702 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Tue, 08 Oct 2019 13:49:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191008/a0f565b0/attachment.htm>