Change in ...osmo-sgsn[master]: sgsn: MM Gb Fsm: fix event handling for implicit detach

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Oct 8 13:43:17 UTC 2019


lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15553 )

Change subject: sgsn: MM Gb Fsm: fix event handling for implicit detach
......................................................................

sgsn: MM Gb Fsm: fix event handling for implicit detach

Implicit detach means there won't be any Gb state afterwards.

Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
---
M src/sgsn/gprs_mm_state_gb_fsm.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved



diff --git a/src/sgsn/gprs_mm_state_gb_fsm.c b/src/sgsn/gprs_mm_state_gb_fsm.c
index 02f6747..f6d680c 100644
--- a/src/sgsn/gprs_mm_state_gb_fsm.c
+++ b/src/sgsn/gprs_mm_state_gb_fsm.c
@@ -47,9 +47,11 @@
 
 	switch(event) {
 	case E_MM_READY_TIMER_EXPIRY:
-	case E_MM_IMPLICIT_DETACH:
 		mm_state_gb_fsm_state_chg(fi, ST_MM_STANDBY);
 		break;
+	case E_MM_IMPLICIT_DETACH:
+		mm_state_gb_fsm_state_chg(fi, ST_MM_IDLE);
+		break;
 	case E_MM_PDU_RECEPTION:
 		/* RE-arm the READY timer upon receival of Gb PDUs */
 		t_secs = osmo_tdef_get(sgsn->cfg.T_defs, 3314, OSMO_TDEF_S, -1);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15553
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
Gerrit-Change-Number: 15553
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191008/48313db6/attachment.htm>


More information about the gerrit-log mailing list