Change in ...osmo-sgsn[master]: gprs_gmm: release Iu connection on RAU failures

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Oct 8 11:54:01 UTC 2019


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15551 )

Change subject: gprs_gmm: release Iu connection on RAU failures
......................................................................


Patch Set 8:

(1 comment)

> Patch Set 6:
> 
> In here the code comment was removed but the code was not changed as asked in the gerrit comment?

I've removed the comment in the code. The correct cause code should be fixed via

https://gerrit.osmocom.org/#/c/15551/8/src/sgsn/gprs_gmm.c 
File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/#/c/15551/8/src/sgsn/gprs_gmm.c@1704 
PS8, Line 1704: 		ranap_iu_tx_release_free(MSG_IU_UE_CTX(msg), NULL, 5);
> So is 5 the correct cause code? What is 5? use some define?
The cause code is set to NULL, which means, it should use the default cause code.
5 is a timeout for closing the connection. I'll use a define for it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15551
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I05a9200f55d608ccfb3f86184c324a2b428da76b
Gerrit-Change-Number: 15551
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2019 11:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191008/3877557e/attachment.htm>


More information about the gerrit-log mailing list