This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orgHello Hoernchen, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15689 to review the following change. Change subject: WIP: change IRQ endpoint re-submit logic. ...................................................................... WIP: change IRQ endpoint re-submit logic. Why? Change-Id: I41e77eec5f01bf082f8cb7331fbf7baae1c132ed --- M sysmoOCTSIM/main.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/89/15689/1 diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 9ef7f2f..6e2d6ac 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -220,7 +220,9 @@ struct msgb *msg; int rc; - OSMO_ASSERT(!ep_q->in_progress); + if (ep_q->in_progress) + return 0; + msg = msgb_dequeue_irqsafe(&ep_q->list); if (!msg) return 0; @@ -1110,6 +1112,7 @@ while (true) { // main loop command_try_recv(); poll_card_detect(); + submit_next_irq(); osmo_timers_update(); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I41e77eec5f01bf082f8cb7331fbf7baae1c132ed Gerrit-Change-Number: 15689 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191007/550bfbe9/attachment.htm>