Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3169

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Oct 7 09:09:30 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15676 )

Change subject: pcu: Introduce test TC_t3169
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn 
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn@658 
PS2, Line 658: f_rx_pcuif_rlcmac_dl_block_exp_dummy
> Same comment as for 15675, do we really need to create functions for such basic things? IMHO, this d […]
I think it's handy once you start adding more and more tests and you end up having test files with 3K lines, at least we get rid of a few lines ;)
When tests start to become more complex I think it really helps because you can abstract implementation details (like how you are matching exactly, error conditions, etc.). Furthermore if you want to do more checks, you simply extend one part of the code instead of having to apply same change all over.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15676
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I587413a7de7956daee3423057530e4052a55ba88
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Oct 2019 09:09:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191007/4b411d5d/attachment.htm>


More information about the gerrit-log mailing list