Change in ...libosmo-netif[master]: osmux: osmux_snprintf(): Remove dangling whitespace at the end of dum...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Oct 4 11:51:09 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15668 )

Change subject: osmux: osmux_snprintf(): Remove dangling whitespace at the end of dummy frames
......................................................................

osmux: osmux_snprintf(): Remove dangling whitespace at the end of dummy frames

Change-Id: I1ef73807c3300cbcc332f32e6bb905d9b30557be
---
M src/osmux.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmux.c b/src/osmux.c
index 43b294c..9d058b0 100644
--- a/src/osmux.c
+++ b/src/osmux.c
@@ -1032,7 +1032,7 @@
 	ret = snprintf(buf, remain, "OSMUX seq=%03u ccid=%03u "
 				 "ft=%01u ctr=%01u "
 				 "amr_f=%01u amr_q=%01u "
-				 "amr_ft=%02u amr_cmr=%02u ",
+				 "amr_ft=%02u amr_cmr=%02u",
 			osmuxh->seq, osmuxh->circuit_id,
 			osmuxh->ft, osmuxh->ctr,
 			osmuxh->amr_f, osmuxh->amr_q,
@@ -1126,6 +1126,8 @@
 			}
 
 			if (osmuxh->ft == OSMUX_FT_VOICE_AMR) {
+				ret = snprintf(buf + offset, remain, " ");
+				SNPRINTF_BUFFER_SIZE(ret, remain, offset);
 				ret = osmux_snprintf_payload(buf + offset, remain,
 							     osmux_get_payload(osmuxh),
 							     payload_len);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/15668
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I1ef73807c3300cbcc332f32e6bb905d9b30557be
Gerrit-Change-Number: 15668
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191004/329bc895/attachment.htm>


More information about the gerrit-log mailing list