Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce some function helpers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Oct 3 19:22:39 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664 )

Change subject: pcu: Introduce some function helpers
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Cool! I was also thinking about introducing some kind of abstraction functions.

https://gerrit.osmocom.org/#/c/15664/1/pcu/PCU_Tests_RAW.ttcn 
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/#/c/15664/1/pcu/PCU_Tests_RAW.ttcn@570 
PS1, Line 570: f_pad_oct(data, 23, '00'O); /* CS-1 */
We may want different coding schemes in the future, so the amount of padding may vary. I recommend to add another parameter of type ChCodingCommand, which will define the amount of padding.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8608fac4375153d5020df5d05026513a7fe931d6
Gerrit-Change-Number: 15664
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Oct 2019 19:22:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191003/6335cd77/attachment.htm>


More information about the gerrit-log mailing list