Change in ...osmo-bts[master]: scheduler: Use OSMO_ASSERT instead of abort

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Oct 2 15:55:06 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15655


Change subject: scheduler: Use OSMO_ASSERT instead of abort
......................................................................

scheduler: Use OSMO_ASSERT instead of abort

Change-Id: I594842b08cdb97a473273ba7097a05502f5751b8
---
M src/common/scheduler.c
1 file changed, 3 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/55/15655/1

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 52edcbf..40e0a54 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -29,6 +29,7 @@
 #include <osmocom/core/msgb.h>
 #include <osmocom/core/talloc.h>
 #include <osmocom/core/bits.h>
+#include <osmocom/core/utils.h>
 
 #include <osmocom/gsm/protocol/gsm_08_58.h>
 #include <osmocom/gsm/a5.h>
@@ -780,8 +781,7 @@
 		"PH-DATA.req: chan_nr=0x%02x link_id=0x%02x\n",
 		l1sap->u.data.chan_nr, l1sap->u.data.link_id);
 
-	if (!l1sap->oph.msg)
-		abort();
+	OSMO_ASSERT(l1sap->oph.msg);
 
 	/* ignore empty frame */
 	if (!msgb_l2len(l1sap->oph.msg)) {
@@ -802,8 +802,7 @@
 	LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, -1, l1sap->u.tch.fn, "TCH.req: chan_nr=0x%02x\n",
 		l1sap->u.tch.chan_nr);
 
-	if (!l1sap->oph.msg)
-		abort();
+	OSMO_ASSERT(l1sap->oph.msg);
 
 	/* ignore empty frame */
 	if (!msgb_l2len(l1sap->oph.msg)) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15655
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I594842b08cdb97a473273ba7097a05502f5751b8
Gerrit-Change-Number: 15655
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191002/8682d390/attachment.htm>


More information about the gerrit-log mailing list