Change in libosmocore[master]: 04.80: Deprecate gsm0480_create_ussd_resp()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Nov 30 12:39:55 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16344 )

Change subject: 04.80: Deprecate gsm0480_create_ussd_resp()
......................................................................

04.80: Deprecate gsm0480_create_ussd_resp()

In July 2018 in commit Ide240279240322f643e142229eb7829f538c6314 we
introduced the successor gsm0480_gen_ussd_resp_7bit(), which is also
what both libosmogsm-internal code as well as osmo-hlr have been ported
to.  For some reason it wasn't marked deprecated back then.

Change-Id: Iff4c91b5b98a73d9a30aa42f6b2a1ebcc8a45343
---
M src/gsm/gsm0480.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index 3ae591a..1d5cde9 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -821,6 +821,7 @@
  * not only the FACILITY value, but the full L3 message including message header
  * and FACILITY IE Tag+Length.
  */
+OSMO_DEPRECATED("Use gsm0480_gen_ussd_resp_7bit() instead")
 struct msgb *gsm0480_create_ussd_resp(uint8_t invoke_id, uint8_t trans_id, const char *text)
 {
 	struct msgb *msg;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16344
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iff4c91b5b98a73d9a30aa42f6b2a1ebcc8a45343
Gerrit-Change-Number: 16344
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191130/27c60817/attachment.htm>


More information about the gerrit-log mailing list