Change in osmo-msc[master]: libmsc/gsm_04_11.c: fix: include the length byte in SM-RP-DA

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Nov 30 10:26:47 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/16341 )


Change subject: libmsc/gsm_04_11.c: fix: include the length byte in SM-RP-DA
......................................................................

libmsc/gsm_04_11.c: fix: include the length byte in SM-RP-DA

Change-Id: I64f47fb68e8123f47d7770b7cb194c57acef1e8f
---
M src/libmsc/gsm_04_11.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/16341/1

diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index 367cc6f..7a5e263 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -759,7 +759,8 @@
 
 	LOG_TRANS(trans, LOGL_DEBUG, "DST(%u,%s)\n", dst_len, osmo_hexdump(dst, dst_len));
 
-	return gsm411_rx_rp_ud(msg, trans, rph, dst, dst_len);
+	/* Include the L part, so we can use gsm48_decode_bcd_number() */
+	return gsm411_rx_rp_ud(msg, trans, rph, dst - 1, dst_len + 1);
 }
 
 static struct gsm_sms *sms_report_alloc(struct gsm_sms *sms, struct gsm_trans *trans)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16341
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I64f47fb68e8123f47d7770b7cb194c57acef1e8f
Gerrit-Change-Number: 16341
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191130/a30d6e66/attachment.htm>


More information about the gerrit-log mailing list