This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337 ) Change subject: pcu: Introduce tests to check UL CS initial and max ...................................................................... Patch Set 2: Code-Review+1 (5 comments) Fine in general, just a few cosmetic comments. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1120 PS2, Line 1120: lqual_cb := 0; No need to initialize it here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1172 PS2, Line 1172: match Can we just compare them like: last_ch_coding == CH_CODING_CS3? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1197 PS2, Line 1197: match Can we just compare them like: last_ch_coding == CH_CODING_CS1? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1236 PS2, Line 1236: 15 Cosmetic: actually, 16 (I also made this mistake in TC_cs_lqual_ul_tbf). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1258 PS2, Line 1258: match same here -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3aa654e6f678698e5b8cb4914f1ca5b39fc08568 Gerrit-Change-Number: 16337 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 29 Nov 2019 17:17:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191129/4b3c363e/attachment.htm>