Change in osmo-ttcn3-hacks[master]: introduce MNCC_Emulation mp_mncc_version

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Nov 28 22:39:50 UTC 2019


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16322 )

Change subject: introduce MNCC_Emulation mp_mncc_version
......................................................................

introduce MNCC_Emulation mp_mncc_version

Default the MNCC version to the current osmo-sip-connector's master branch MNCC
version.

As soon as the new version (6) is merged, we can bump it here to make tests for
master work again.

For 'latest' builds, we can adjust osmo-ttcn3-hacks to use version 5, and also
see those tests still passing.

Change-Id: I3eb6e0132dc99ebe41a98cc5c329ed4864b770d6
---
M library/MNCC_Emulation.ttcn
M sip/SIP_Tests.default
2 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/library/MNCC_Emulation.ttcn b/library/MNCC_Emulation.ttcn
index ee9b58e..9522e72 100644
--- a/library/MNCC_Emulation.ttcn
+++ b/library/MNCC_Emulation.ttcn
@@ -37,6 +37,10 @@
 import from MNCC_Types all;
 import from UD_Types all;
 
+modulepar {
+	int mp_mncc_version := 5;
+}
+
 /* General "base class" component definition, of which specific implementations
  * derive themselves by means of the "extends" feature */
 type component MNCC_ConnHdlr {
@@ -264,7 +268,7 @@
 
 	if (role_server) {
 		f_listen(sock);
-		MNCC.send(t_SD_MNCC(g_mncc_ud_id, ts_MNCC_HELLO));
+		MNCC.send(t_SD_MNCC(g_mncc_ud_id, ts_MNCC_HELLO(version := mp_mncc_version)));
 	} else {
 		f_connect(sock);
 	}
diff --git a/sip/SIP_Tests.default b/sip/SIP_Tests.default
index 4434a1a..9fcd387 100644
--- a/sip/SIP_Tests.default
+++ b/sip/SIP_Tests.default
@@ -25,6 +25,7 @@
 
 [MODULE_PARAMETERS]
 Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoSIPcon";
+MNCC_Emulation.mp_mncc_version := 5;
 
 [MAIN_CONTROLLER]
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16322
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3eb6e0132dc99ebe41a98cc5c329ed4864b770d6
Gerrit-Change-Number: 16322
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191128/0dd23eac/attachment.htm>


More information about the gerrit-log mailing list