Change in libosmo-sccp[master]: Skip dynamic ASPs when writing the list of ASPs in an AS

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16305 )

Change subject: Skip dynamic ASPs when writing the list of ASPs in an AS
......................................................................

Skip dynamic ASPs when writing the list of ASPs in an AS

we handle this correctly in not writing the actual "asp" configuration,
but we have a bug when writing the list of asps within one "as". Let's
make sure to skip the dynamically-created ASPs there, too.

Change-Id: I1a184f3ddec2e91ced8c95ada224da8b490407a8
Closes: OS#4284
---
M src/osmo_ss7_vty.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index ebae5a5..591254e 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -1044,6 +1044,9 @@
 		struct osmo_ss7_asp *asp = as->cfg.asps[i];
 		if (!asp)
 			continue;
+		/* skip any dynamically created ASPs (e.g. auto-created at connect time) */
+		if (asp->dyn_allocated || asp->simple_client_allocated)
+			continue;
 		vty_out(vty, "  asp %s%s", asp->cfg.name, VTY_NEWLINE);
 	}
 	if (as->cfg.mode_set_by_vty)

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16305
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I1a184f3ddec2e91ced8c95ada224da8b490407a8
Gerrit-Change-Number: 16305
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191128/54c47b6e/attachment.htm>