Change in osmo-ccid-firmware[master]: add the talloc ctx to struct ccid_instance

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Nov 28 20:31:42 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16318 )

Change subject: add the talloc ctx to struct ccid_instance
......................................................................


Patch Set 1:

It's a bit of a question of taste.  I would state we typically don't put talloc contexts in objects that are themselves not talloc-allocated (like g_ci which is statically allocated).

Also, having the same talloc context (or really any information) stored twice seems a bit odd to me.  But if you insist, go ahead...


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16318
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I3b73e68d0347d74f68018614613fcc802f3fdfe7
Gerrit-Change-Number: 16318
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 28 Nov 2019 20:31:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191128/31f8c784/attachment.htm>


More information about the gerrit-log mailing list