Change in osmo-sip-connector[master]: logging from sofia: add missing newline

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Nov 28 20:17:28 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/16220 )

Change subject: logging from sofia: add missing newline
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-sip-connector/+/16220/1/src/sip.c 
File src/sip.c:

https://gerrit.osmocom.org/c/osmo-sip-connector/+/16220/1/src/sip.c@674 
PS1, Line 674: 		char *end = log_line + OSMO_MIN(strlen(log_line), sizeof(log_line) - 2);
> No need to strlen(log_line) here, you should have available information from return of vsnprintf abo […]
Because of the OSMO_MIN() with the sizeof, you are actually correct.
Just to make sure for future patches: vsnprintf() returns the strlen that *would* be written if the buffer were large enough. If that OSMO_MIN() weren't there, vsnprintf's rc would *not* qualify to ensure staying inside the buf.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/16220
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ia26c0b57a0166cf7de87c49471ce6f528a366dd5
Gerrit-Change-Number: 16220
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Nov 2019 20:17:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191128/bb9e19b2/attachment.htm>


More information about the gerrit-log mailing list