This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16283 ) Change subject: fix power descriptor value ...................................................................... fix power descriptor value The previous value would allow using the device without external power, i.e. on a hub, which leads to silent failures trying to power up the slots (nothing happens, no atr will be received) Change-Id: I40c48ea56151d13de362b8f73cae5b21aba0ebfa FIXME: The device should offer at least one 100mA configuration. --- M sysmoOCTSIM/usb_descriptors.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sysmoOCTSIM/usb_descriptors.c b/sysmoOCTSIM/usb_descriptors.c index 63ace0c..beb1633 100644 --- a/sysmoOCTSIM/usb_descriptors.c +++ b/sysmoOCTSIM/usb_descriptors.c @@ -52,7 +52,8 @@ .bConfigurationValue = CONF_USB_CDCD_ACM_BCONFIGVAL, .iConfiguration = STR_DESC_CONFIG, .bmAttributes = CONF_USB_CDCD_ACM_BMATTRI, - .bMaxPower = CONF_USB_CDCD_ACM_BMAXPOWER, + /* FIXME: The device should offer at least one 100mA configuration. */ + .bMaxPower = 250, /* request 500mA */ }, .cdc = { .comm = { -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I40c48ea56151d13de362b8f73cae5b21aba0ebfa Gerrit-Change-Number: 16283 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191128/dbf76742/attachment.htm>