Change in osmo-ccid-firmware[master]: don't wait for TCK if card only supports T0

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16264 )

Change subject: don't wait for TCK if card only supports T0
......................................................................

don't wait for TCK if card only supports T0

See 7816-3 8.2.5, T0 only (maybe implicitly) and no T15 = no TCK.
This could be handled by a timeout instead, but timeouts don't work yet.

Change-Id: Ice7bc4e603bbbbef88258af41f61e14a06727add
---
M ccid_common/iso7816_fsm.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c
index 21378e0..beda7ab 100644
--- a/ccid_common/iso7816_fsm.c
+++ b/ccid_common/iso7816_fsm.c
@@ -633,6 +633,10 @@
 					osmo_fsm_inst_state_chg_ms(fi, ATR_S_WAIT_TCK,
 								   guard_time_ms, T_GUARD);
 					break;
+				} else {
+					/* no TCK present, ATR complete; notify parent */
+					osmo_fsm_inst_state_chg(fi, ATR_S_DONE, 0, 0);
+					osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_ATR_DONE_IND, atp->atr);
 				}
 			} else {
 				break;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16264
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ice7bc4e603bbbbef88258af41f61e14a06727add
Gerrit-Change-Number: 16264
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191128/a802854b/attachment.htm>