This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16202 ) Change subject: add libosmo-mslookup and mDNS implementation ...................................................................... Patch Set 11: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-hlr/+/16202/11/include/osmocom/hlr/logging.h File include/osmocom/hlr/logging.h: https://gerrit.osmocom.org/c/osmo-hlr/+/16202/11/include/osmocom/hlr/logging.h@11 PS11, Line 11: DMSLKP, I don't like this name. It reads like "Measle Key Performance" or "M-Slick-P" or "MS Lock-up". There is no problem with having a long log category name. We have DLGLOBAL, and even if DMSLOOKUP is one letter more, I prefer having a readable log category than saving three vocals. I'm all for <beer brand>'s book of longest category name. If reviewers insist on a shorter name, then let's rather do DLOOKUP or DMSLOOK. I don't see a reason why we need to, though. Let's not be too eager to apply every review bike shed to the patches immediately, let's rather focus on the design of the system. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I83487ab8aad1611eb02e997dafbcb8344da13df1 Gerrit-Change-Number: 16202 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 27 Nov 2019 01:12:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191127/df0d6da8/attachment.htm>