Change in osmo-ccid-firmware[master]: setparameters/PPS works

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237 )

Change subject: setparameters/PPS works
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/ccid_device.c 
File ccid_common/ccid_device.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/ccid_device.c@27 
PS1, Line 27: //	if (in->bmTCCKST0 & 0xFD)
            : //		return -11;
            : // 6.1.7 say
Osmocom uses mainly kernel coding style and hence /* style comments.


https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/iso7816_fsm.c 
File ccid_common/iso7816_fsm.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/iso7816_fsm.c@383 
PS1, Line 383: //	struct iso7816_3_priv *ip = get_iso7816_3_priv(parent_fi);
remove?


https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/iso7816_fsm.c@389 
PS1, Line 389: 		break;
remove?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I2e226b0033f8a147fad60a33a63cc45ee9adc756
Gerrit-Change-Number: 16237
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 26 Nov 2019 23:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191126/53dec035/attachment.htm>