Change in libosmocore[master]: libosmovty: simplify condition checking vty->fd in vty_close()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Nov 26 06:51:56 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16149 )

Change subject: libosmovty: simplify condition checking vty->fd in vty_close()
......................................................................


Patch Set 1:

> So I see what this is about, but my bikeshed is: just keep the previous version :P

We can add a comment to make it cleaner, but I will not insist on merging this change. Even Pau is not 100% (CR+1) sure despite he suggested this ;)


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ied35d142af0ba0f5ad78975b8f22c35b32d6ff71
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Nov 2019 06:51:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191126/84f73941/attachment.htm>


More information about the gerrit-log mailing list