Change in libosmocore[master]: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

[neels]

Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmocore/+/16189

to look at the new patch set (#3).

Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*()
......................................................................

add osmo_gsup_make_response() and osmo_gsup_message_name_*()

As I am implementing GSUP proxy forwarding between osmo-hlr instances, it
becomes apparent that many code paths omit to copy back essential information
in replies to GSUP requests.

Provide a definitive common function that ensures a response can be routed back
to the sender via proxies, with all message fields reflecting the same
subscriber, session identification and message realm.

It is up to osmo-hlr's GSUP server and all clients to use this function in all
relevant GSUP message composition. The most important user is osmo-hlr, which
for now does all proxy routing tasks for directly attached clients.

However, if a core network entity other than the home HLR of a subscriber
launches an MT request, client programs like osmo-msc should also ensure to use
this function, so that responses are sure to reach the requesting peer.

osmo_gsup_message_name_*() are useful to check the osmo_gsup_make_response()
results in gsup_test.c, and are also otherwise useful for debug logging. So far
it prints exactly those elements required to be copied to a response.

Change-Id: Id9692880079ea0f219f52d81b1923a76fc640566
---
M include/osmocom/gsm/gsup.h
M src/gsm/gsup.c
M src/gsm/libosmogsm.map
M tests/gsup/gsup_test.c
M tests/gsup/gsup_test.ok
5 files changed, 245 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/16189/3
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16189
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id9692880079ea0f219f52d81b1923a76fc640566
Gerrit-Change-Number: 16189
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191124/471610b3/attachment.htm>