Change in libosmocore[master]: vty: track parent nodes also for telnet sessions

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16162 )

Change subject: vty: track parent nodes also for telnet sessions
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/16162/2/include/osmocom/vty/vty.h 
File include/osmocom/vty/vty.h:

https://gerrit.osmocom.org/c/libosmocore/+/16162/2/include/osmocom/vty/vty.h@189 
PS2, Line 189: 	int (*is_config_node)(struct vty *vty, int node);
> worth checking if a field in a struct can be marked as deprecated.
this compiles fine:

        int (*is_config_node)(struct vty *vty, int node)
                OSMO_DEPRECATED("Implicit parent node tracking has replaced the use of this callback. This callback is no longer called, ever, and can be left NULL.");

but seems to have no effect: even though osmo-hlr's hlr.c sets an .is_config_node, the compilation doesn't show any deprecation warning.

We can decide in the subsequent patch whether we also want to add the OSMO_DEPRECATED warning https://gerrit.osmocom.org/c/libosmocore/+/16188



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16162
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2b32b4fe20732728db6e9cdac7e484d96ab86dc5
Gerrit-Change-Number: 16162
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 24 Nov 2019 19:02:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191124/e7f7103b/attachment.htm>