Change in osmo-bsc[master]: fsm: use deferred deallocation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Nov 23 08:03:40 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15841 )

Change subject: fsm: use deferred deallocation
......................................................................

fsm: use deferred deallocation

Since osmo-bsc uses the MGCP client FSMs, it is required to enable this new
feature to guarantee safe operation. The issue is described in detail in commit
logs linked below.

Depends: Ief4dba9ea587c9b4aea69993e965fbb20fb80e78 (libosmocore),
         I0adc13a1a998e953b6c850efa2761350dd07e03a (libosmocore)
Related: I7df2e9202b04e7ca7366bb0a8ec53cf3bb14faf3 (osmo-mgw)
Change-Id: Ib7fce7b7d54dfb87af97544796680919e5929a50
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index 0fe35b3..da2914d 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -821,6 +821,8 @@
 	osmo_stats_init(tall_bsc_ctx);
 	rate_ctr_init(tall_bsc_ctx);
 
+	osmo_fsm_set_dealloc_ctx(OTC_SELECT);
+
 	/* Allocate global gsm_network struct */
 	rc = bsc_network_alloc();
 	if (rc) {
@@ -939,7 +941,7 @@
 	}
 
 	while (1) {
-		osmo_select_main(0);
+		osmo_select_main_ctx(0);
 	}
 
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib7fce7b7d54dfb87af97544796680919e5929a50
Gerrit-Change-Number: 15841
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191123/245679ca/attachment.htm>


More information about the gerrit-log mailing list