Change in osmo-pcu[master]: pcuif_proto.h: extend RACH.ind with TRX / TS numbers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Nov 23 08:02:20 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16084 )

Change subject: pcuif_proto.h: extend RACH.ind with TRX / TS numbers
......................................................................

pcuif_proto.h: extend RACH.ind with TRX / TS numbers

Since there can be multiple PDCH channels configured on different
timeslots, different TRXes, and BTSes, the PTCCH/U handling code
in OsmoPCU needs to know the exact origin of a given RACH.ind.

Otherwise, it is not known which subscriber originated a given
PTCCH/U indication, and hence it is impossible to send PTCCH/D
Timing Advance notification properly.

Fortunately, we can extend the RACH.ind message without even
bumping the protocol version, because every single PDU has a
fixed size defined by the largest message - INFO.ind. In case
if the actual message payload is smaller, the rest is filled
with a constant padding byte (0x00).

Older versions of OsmoPCU will consider the new fields as padding,
while the messages from older OsmoBTS versions will always have
both fields set to 0x00. Since C0/TS0 cannot be configured to
PDCH, this can be easily detected on the other end.

Change-Id: If209001885ffb14b64a8e808df3700d85a4b2ef9
Related: OS#1545
---
M include/osmocom/pcu/pcuif_proto.h
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/include/osmocom/pcu/pcuif_proto.h b/include/osmocom/pcu/pcuif_proto.h
index fd989a5..e88607e 100644
--- a/include/osmocom/pcu/pcuif_proto.h
+++ b/include/osmocom/pcu/pcuif_proto.h
@@ -108,6 +108,8 @@
 	uint16_t	arfcn;
 	uint8_t		is_11bit;
 	uint8_t		burst_type;
+	uint8_t		trx_nr;
+	uint8_t		ts_nr;
 } __attribute__ ((packed));
 
 struct gsm_pcu_if_info_trx {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16084
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If209001885ffb14b64a8e808df3700d85a4b2ef9
Gerrit-Change-Number: 16084
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191123/13e37805/attachment.htm>


More information about the gerrit-log mailing list