Change in osmo-ttcn3-hacks[master]: VPCD protocol support (for vsmartcard.git PCD/PICC code)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Nov 22 22:55:19 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16175 )

Change subject: VPCD protocol support (for vsmartcard.git PCD/PICC code)
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16175/1/library/VPCD_CodecPort_CtrlFunct.ttcn 
File library/VPCD_CodecPort_CtrlFunct.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16175/1/library/VPCD_CodecPort_CtrlFunct.ttcn@3 
PS1, Line 3:   import from VPCD_CodecPort all;
Usually we put all these lines without indentation right?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16175/1/library/VPCD_CodecPort_CtrlFunctDef.cc 
File library/VPCD_CodecPort_CtrlFunctDef.cc:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16175/1/library/VPCD_CodecPort_CtrlFunctDef.cc@16 
PS1, Line 16:   
whitespace, not sure if this is somehow autogenrated.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16175
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iac37dd231a0f2e1efd484887bca1a9d672b446bb
Gerrit-Change-Number: 16175
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Nov 2019 22:55:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191122/ecc76b58/attachment.htm>


More information about the gerrit-log mailing list