Change in osmo-bts[master]: rsl: ensure measurement reports are sent

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Nov 22 14:29:19 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16170 )

Change subject: rsl: ensure measurement reports are sent
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Please fix at least 1). The approach described in 2) can be implemented later.

https://gerrit.osmocom.org/c/osmo-bts/+/16170/1/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/16170/1/src/common/scheduler.c@194 
PS1, Line 194: rx_tchf_fn
How about TCH/H?

Also, I don't think it's a good idea to use generic Uplink handlers directly: 1) NOPE.ind contains no burst (actually an uninitialized buffer), so that would result in accessing uninitialized memory (Coverity will be unhappy, ASAN too); 2) TCH coding involves much less redundancy than xCCH, so losing one burst would probably mean we've lost the whole frame (or even two, due to block-diagonal interleaving) - needs to be checked though.

We should probably think about a wrapper function that would check the burst mask (i.e. how many bursts are lost), and either call the corresponding generic handler (e.g. rx_tchf_fn), or update the logical channel state and simply send BFI. This would allow do save some CPU power when we sure that Viterbi decoder would definitely fail.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16170
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Idfa8ef94e8cf131ff234dac8f93f337051663ae2
Gerrit-Change-Number: 16170
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 14:29:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191122/ccd99f04/attachment.htm>


More information about the gerrit-log mailing list