Change in libosmocore[master]: logging/vty: fix: actually ignore deprecated commands, do not abort

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Nov 20 17:23:59 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16140 )


Change subject: logging/vty: fix: actually ignore deprecated commands, do not abort
......................................................................

logging/vty: fix: actually ignore deprecated commands, do not abort

We shall not prevent programs from starting if their configuration
files contain deprecated commands. Just print a warning and return
CMD_SUCCESS instead of CMD_WARNING.

Change-Id: Ia934581410cd41594791d4e14ee74c16abe1009a
Fixes: Ic9c1b566ec4a459f03e6319cf369691903cf9d00
---
M src/vty/logging_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/40/16140/1

diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c
index b4c3776..07bc26b 100644
--- a/src/vty/logging_vty.c
+++ b/src/vty/logging_vty.c
@@ -998,7 +998,7 @@
 static int log_deprecated_func(struct cmd_element *cmd, struct vty *vty, int argc, const char *argv[])
 {
 	vty_out(vty, "%% Ignoring deprecated '%s'%s", cmd->string, VTY_NEWLINE);
-	return CMD_WARNING;
+	return CMD_SUCCESS; /* Otherwise a program would terminate immediately */
 }
 
 void logging_vty_add_deprecated_subsys(void *ctx, const char *name)

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16140
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia934581410cd41594791d4e14ee74c16abe1009a
Gerrit-Change-Number: 16140
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191120/eed742c1/attachment.htm>


More information about the gerrit-log mailing list