This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16082 ) Change subject: PTCCH: implement basic message codec and API ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/16082/1/src/pdch.h File src/pdch.h: https://gerrit.osmocom.org/c/osmo-pcu/+/16082/1/src/pdch.h@98 PS1, Line 98: #ifdef __cplusplus > Move this block upwards to be inside the other cplusplus block. I would want to keep this as a separate block with PTCCH specific API. https://gerrit.osmocom.org/c/osmo-pcu/+/16082/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/16082/1/src/pdch.cpp@970 PS1, Line 970: memset(ptcch_msg + PTCCH_TAI_NUM, PTCCH_PADDING, 7); > what is this 7? It's padding length. Could be: * sizeof(ptcch_msg) - PTCCH_TAI_NUM; * GSM_MACBLOCK_LEN - PTCCH_TAI_NUM; * another #define PTCCH_PAD_LEN. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id79e95aafdde4a71977c64385fce48b729a51ca9 Gerrit-Change-Number: 16082 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2019 12:34:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191118/dd413287/attachment.htm>