Change in osmo-sgsn[master]: gmm: Fix assertion hit during RA UPD REQ before completting gmm attach

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16015 )

Change subject: gmm: Fix assertion hit during RA UPD REQ before completting gmm attach
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/16015/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-sgsn/+/16015/1//COMMIT_MSG@20 
PS1, Line 20: MS/PCU answers immediatelly with a RA Update instead with a new RA
            : ID.
> So this is absolutely legal, and that's why we should not assert(), right?
Yes, I initially added an assert() while trying to debug the bug report since I was unable to find clear crash paths and I was suspecting this one could be, but I needed to be able to have a clear scenario (because in the bug report the crash happened afterwards in time due to memory corruption). Now thanks to osmo-gsm-tester I was able to find the scenario and reproduce it, and in that case we simply need to make sure the llme is nulled so it's not used later after being freed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/16015
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I64fa5cf1b427d3abb99e553e584897261a827ce6
Gerrit-Change-Number: 16015
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 15 Nov 2019 18:21:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191115/83149e23/attachment.htm>