Change in osmo-bts[master]: Apply latests improvements from loops.c to power_control.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Nov 14 18:05:35 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16070 )

Change subject: Apply latests improvements from loops.c to power_control.c
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/16070/1/src/common/power_control.c 
File src/common/power_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/16070/1/src/common/power_control.c@56 
PS1, Line 56: 	if (lchan->ms_power_ctrl.current != ms_power)
This line, as the TODO indicates, its breaking ms power loop for phones not supporting al ms power levels.
For instance, I announce MS Power level 31 at first, and I have a phone only supporting up to level 0 (the one immediatelly below in signal strength), so power loop never continues to reach an expected power level 15 (0dbm).

However, In here I'm simply applying other fixes from loops.c, so it can be merged anyway and this issue will be fixed later.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16070
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I579967cc8bb69dc76a315c6c9d3a351f5961d92f
Gerrit-Change-Number: 16070
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Nov 2019 18:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191114/e6765776/attachment.htm>


More information about the gerrit-log mailing list