Change in libosmo-sccp[master]: ss7: Improve log formatting during ASP restart

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Nov 12 14:18:40 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16012 )

Change subject: ss7: Improve log formatting during ASP restart
......................................................................

ss7: Improve log formatting during ASP restart

Since it may act sometimes as a server and sometimes as a client, let's
better use one more neutral (2-side arrow) connector, and mark which
address is the local and which is the remote. We already use same
formatting in other osmocom code.

Change-Id: I42feaa16790f02b98bcda65281de8cd9295ddcb6
---
M src/osmo_ss7.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 7ff3efe..4d5c349 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1292,8 +1292,8 @@
 	OSMO_ASSERT(ss7_initialized);
 	osmo_ss7_asp_peer_snprintf(bufloc, sizeof(bufloc), &asp->cfg.local);
 	osmo_ss7_asp_peer_snprintf(bufrem, sizeof(bufrem), &asp->cfg.remote);
-	LOGPASP(asp, DLSS7, LOGL_INFO, "Restarting ASP %s, %s ==> %s\n",
-	       asp->cfg.name, bufloc, bufrem);
+	LOGPASP(asp, DLSS7, LOGL_INFO, "Restarting ASP %s, r=%s<->l=%s\n",
+	       asp->cfg.name, bufrem, bufloc);
 
 	if (!asp->cfg.is_server) {
 		/* We are in client mode now */

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16012
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I42feaa16790f02b98bcda65281de8cd9295ddcb6
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191112/a7f1042f/attachment.htm>


More information about the gerrit-log mailing list