This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16048 ) Change subject: tests/db_upgrade: disable for old sqlite versions ...................................................................... tests/db_upgrade: disable for old sqlite versions Skip the test if the installed sqlite version is older than 3.16.2 (current version of debian 9). This prevents test failures caused by the way we dump tables in the test, which does not work with older versions. This patch is a middle ground between reverting the db upgrade patch, and spending lots of time to replace the table dumping code with something that works with old sqlite versions to fix current build failures in OBS. Usually version checking is done in configure.ac, however I could not find a good way to pass the result to testsuite.at. So I decided to use pkg-config to do the test there. Fixes: 5b65461d686327ead0cb2a6d8493dfa9173d376c ("add db_upgrade test") Related: https://lists.osmocom.org/pipermail/openbsc/2019-November/013063.html Change-Id: I348c133003a95badbd6807d1519aa669115872fb --- M tests/testsuite.at 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/tests/testsuite.at b/tests/testsuite.at index a8efe42..bd758c9 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -37,7 +37,10 @@ AT_CHECK([$abs_top_builddir/tests/db/db_test], [], [expout], [experr]) AT_CLEANUP +# AT_SKIP_IF: disable for old sqlite versions, because the way we dump tables in the test doesn't work with it. +# https://lists.osmocom.org/pipermail/openbsc/2019-November/013063.html AT_SETUP([db_upgrade]) +AT_SKIP_IF([ ! pkg-config sqlite3 --exists --atleast-version=3.16.2 ]) AT_KEYWORDS([db_upgrade]) cat $abs_srcdir/db_upgrade/db_upgrade_test.ok > expout cat $abs_srcdir/db_upgrade/db_upgrade_test.err > experr -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I348c133003a95badbd6807d1519aa669115872fb Gerrit-Change-Number: 16048 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191112/bb32aa63/attachment.htm>