Change in libosmocore[master]: fix osmo_quote_str_c() to alloc sufficient size

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Nov 12 08:50:29 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16029 )

Change subject: fix osmo_quote_str_c() to alloc sufficient size
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/16029/4/src/utils.c 
File src/utils.c:

https://gerrit.osmocom.org/c/libosmocore/+/16029/4/src/utils.c@775 
PS4, Line 775: The function signature is suitable for OSMO_STRBUF_APPEND_NOLEN().
This seems to be wrong, the description of OSMO_STRBUF_APPEND_NOLEN is:
> Like OSMO_STRBUF_APPEND(), but for function signatures that return the char* buffer instead of a length.

But this function does return the length.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16029
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I04d97e8eec93ffb74006503c356a68cceaf429ac
Gerrit-Change-Number: 16029
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Nov 2019 08:50:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191112/4eef734c/attachment.htm>


More information about the gerrit-log mailing list