Change in osmo-bts[master]: scheduler_trx: initalize n_errors, n_bursts_bits, n_bits_total

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Nov 11 12:37:40 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15908 )

Change subject: scheduler_trx: initalize n_errors, n_bursts_bits, n_bits_total
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/15908/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/15908/1//COMMIT_MSG@9 
PS1, Line 9: the variables n_errors, n_bursts_bits, n_bits_total are always
           : initalized
> As far as I can see from the code, you only initialize n_bits_total.
Done


https://gerrit.osmocom.org/c/osmo-bts/+/15908/2/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/15908/2/src/osmo-bts-trx/scheduler_trx.c@786 
PS2, Line 786: 	int n_errors = 0;;
> Extra ";".
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If28ea11cc111c7d73ca47b25e65ce399e5baa4c1
Gerrit-Change-Number: 15908
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Nov 2019 12:37:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191111/c3ca7f25/attachment.htm>


More information about the gerrit-log mailing list