Change in libosmo-sccp[master]: osmo_ss7.c: fix xua_accept_cb(): properly assign role

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Nov 6 15:54:00 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15988 )

Change subject: osmo_ss7.c: fix xua_accept_cb(): properly assign role
......................................................................

osmo_ss7.c: fix xua_accept_cb(): properly assign role

Most likely, we want all dynamically allocated ASPs to play the SG
role by default. Otherwise when using the following configuration:

  cs7 instance 0
   xua rkm routing-key-allocation dynamic-permitted
   listen m3ua 2905
    accept-asp-connections dynamic-permitted

both OsmoMSC and OsmoBSC fail to establish connections.

Change-Id: Ib904ecf0e5d192a1024863f6f0fdf79301055655
Fixes: I2df9cd9747ad5c9a05d567d9a71bab6184c53674
Related: OS#4247
---
M src/osmo_ss7.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 77e8f72..7ff3efe 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1763,6 +1763,7 @@
 				LOGP(DLSS7, LOGL_INFO, "%s: created dynamic ASP %s\n",
 					sock_name, asp->cfg.name);
 				asp->cfg.is_server = true;
+				asp->cfg.role = OSMO_SS7_ASP_ROLE_SG;
 				asp->cfg.local.host[0] = NULL;
 				asp->cfg.local.host_cnt = 1;
 				asp->cfg.remote.port = atoi(portbuf);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15988
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ib904ecf0e5d192a1024863f6f0fdf79301055655
Gerrit-Change-Number: 15988
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191106/b02b6f53/attachment.htm>


More information about the gerrit-log mailing list