Change in osmo-bts[master]: osmo-bts-trx: general handling of NOPE / IDLE indications

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Nov 6 14:19:33 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15989 )

Change subject: osmo-bts-trx: general handling of NOPE / IDLE indications
......................................................................


Patch Set 1:

(1 comment)

> Are you sure it makes sense to have a specific function for IDLE/NOPE burst indications?

Well, we don't really need this feature for the most logical channels. It's only required for those which change their state. For example, both TCH/F and TCH/H handlers need to shift the burst buffer due to block-diagonal interleaving. We may also want to avoid involving the Viterbi decoding when at least one TCH burst is lost, while for xCCH we can still try (because its redundancy is much higher).

> afaik we don't have that in other osmo-bts models...

Of course. Other BTS models deal with bursts internally, so you only get L2 frames from them.

https://gerrit.osmocom.org/c/osmo-bts/+/15989/1/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/15989/1/src/common/scheduler.c@1363 
PS1, Line 1363: 	/* omit bursts which have no handler, like IDLE bursts */
> In here it says it will return on IDLE bursts, but are adding code below this point to handle them.. […]
'... like IDLE bursts' is just an example meaning that TRXC_IDLE has no Uplink burst handler. Both SCH and FCCH also have no Uplink handlers, neither they exist on the Uplink part of the multiframe layouts. This comment is a bit misleading.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15989
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I71c552f44c25e56e9779d8b8ef5d4de9f8475637
Gerrit-Change-Number: 15989
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Nov 2019 14:19:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191106/cbebd65b/attachment.htm>


More information about the gerrit-log mailing list