Change in osmo-bts[master]: osmo-bts-trx: general handling of NOPE / IDLE indications

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 6 13:33:22 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15989 )

Change subject: osmo-bts-trx: general handling of NOPE / IDLE indications
......................................................................


Patch Set 1:

(1 comment)

Are you sure it makes sense to have a specific function for IDLE/NOPE burst indications? afaik we don't have that in other osmo-bts models... I'd expect to have them sent over usual UL path and then for each specific logical channel do whatever based on it being IDLE or not (for instance lost TCH frames have len=0 but still are sent to increase the RTP clock).

In any case I'd wait to merge this until there's someone using that new fn callback you are adding...

https://gerrit.osmocom.org/c/osmo-bts/+/15989/1/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/15989/1/src/common/scheduler.c@1363 
PS1, Line 1363: 	/* omit bursts which have no handler, like IDLE bursts */
In here it says it will return on IDLE bursts, but are adding code below this point to handle them...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15989
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I71c552f44c25e56e9779d8b8ef5d4de9f8475637
Gerrit-Change-Number: 15989
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Nov 2019 13:33:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191106/bf25cf03/attachment.htm>


More information about the gerrit-log mailing list