Change in libosmo-sccp[master]: osmo_ss7.c: fix xua_accept_cb(): properly assign role

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 6 13:25:33 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15988 )

Change subject: osmo_ss7.c: fix xua_accept_cb(): properly assign role
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/15988/1/src/osmo_ss7.c 
File src/osmo_ss7.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/15988/1/src/osmo_ss7.c@1770 
PS1, Line 1770: 				asp->cfg.role = OSMO_SS7_ASP_ROLE_SG;
Please move it sometwhere else, not between host[0] and host_cnt ;)

And I think that's not correct. According to 1a822635f8e5a389aaae68d2d4fed3e310739129 we still may want the server to be role ASP right?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15988
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ib904ecf0e5d192a1024863f6f0fdf79301055655
Gerrit-Change-Number: 15988
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Nov 2019 13:25:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191106/b1610464/attachment.htm>


More information about the gerrit-log mailing list