Change in osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: move TC_pcu_ptcch to a proper place

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Nov 6 04:56:36 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15869 )

Change subject: BTS_Tests.ttcn: fix: move TC_pcu_ptcch to a proper place
......................................................................

BTS_Tests.ttcn: fix: move TC_pcu_ptcch to a proper place

We have a module parameter 'mp_l1_supports_gprs' that indicates
whether the L1 back-end (trxcon, virt_phy, or Calypso) does
support PDCH and TBF management.

The TC_pcu_ptcch does not require support of TBF management, only
PDCH (namely PTCCH) needs to be supported. This is already
implemented in trxcon, and can be easily implemented for Calypso.

Change-Id: Id2e751e825a7a5128bc3f2e4677d8ef31174b501
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 90281e3..25721e3 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -6356,7 +6356,6 @@
 		execute( TC_pcu_deact_req_wrong_ts() );
 		execute( TC_pcu_ver_si13() );
 		if (mp_l1_supports_gprs) {
-			execute( TC_pcu_ptcch() );
 			execute( TC_pcu_data_req_pdtch() );
 			execute( TC_pcu_data_req_ptcch() );
 			execute( TC_pcu_data_req_wrong_bts() );
@@ -6364,6 +6363,7 @@
 			execute( TC_pcu_data_req_wrong_ts() );
 			execute( TC_pcu_data_req_ts_inactive() );
 		}
+		execute( TC_pcu_ptcch() );
 		execute( TC_pcu_data_req_agch() );
 		execute( TC_pcu_data_req_pch() );
 		execute( TC_pcu_data_req_imm_ass_pch() );

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15869
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id2e751e825a7a5128bc3f2e4677d8ef31174b501
Gerrit-Change-Number: 15869
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191106/244234a6/attachment.htm>


More information about the gerrit-log mailing list