This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15976 ) Change subject: ASP FSM: Permit DOWN -> DOWN "transition" ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-sccp/+/15976/3/src/xua_asp_fsm.c File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/15976/3/src/xua_asp_fsm.c@642 PS3, Line 642: S(XUA_ASP_S_DOWN), Since probably xua_asp_fsm_down_onenter() is called, it may make sense to do something like this in there: if (prev_state != XUA_ASP_S_DOWN) dispatch_to_all_as(fi, XUA_ASPAS_ASP_DOWN_IND); Because I don't see the point in annoying upper layers if there's no real change. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iabbcf92e3022a4c3f165ce19be929915f92b455c Gerrit-Change-Number: 15976 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 05 Nov 2019 20:02:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191105/5f6cca80/attachment.htm>