Change in osmo-bts[master]: bts-trx: Implement MS Power control loop calculations using dBm inste...

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15971 )

Change subject: bts-trx: Implement MS Power control loop calculations using dBm instead of ctl levels
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/15971/1/src/osmo-bts-trx/loops.h 
File src/osmo-bts-trx/loops.h:

https://gerrit.osmocom.org/c/osmo-bts/+/15971/1/src/osmo-bts-trx/loops.h@11 
PS1, Line 11: #define MS_RAISE_MAX_DBM 4
            : #define MS_LOWER_MAX_DBM 8
A relative change to a dBm value is always in dB.  So you are e.g. adding 2dB to a 10dBm value, and you get 12dBm.  So the constants here should end in _DB


https://gerrit.osmocom.org/c/osmo-bts/+/15971/1/src/osmo-bts-trx/loops.c 
File src/osmo-bts-trx/loops.c:

https://gerrit.osmocom.org/c/osmo-bts/+/15971/1/src/osmo-bts-trx/loops.c@58 
PS1, Line 58: retrieve
nitpick: compute? calculate?


https://gerrit.osmocom.org/c/osmo-bts/+/15971/1/src/osmo-bts-trx/loops.c@58 
PS1, Line 58: %d
I'm sure we have a value_string for band names?


https://gerrit.osmocom.org/c/osmo-bts/+/15971/1/src/osmo-bts-trx/loops.c@65 
PS1, Line 65: %d
I'm sure we have a value_string for band names?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15971
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0160637c5ffa606ee3081ad30be8e6f2a42b725b
Gerrit-Change-Number: 15971
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 05 Nov 2019 19:36:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191105/22bf74de/attachment.htm>