Change in osmo-ttcn3-hacks[master]: msc: split off f_mgcp_find_param_entry()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Nov 5 19:30:01 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15963 )

Change subject: msc: split off f_mgcp_find_param_entry()
......................................................................

msc: split off f_mgcp_find_param_entry()

Split f_mgcp_find_param_entry() out of f_mgcp_find_param() to be able to act on
an MgcpParameterList without an enclosing MgcpMessage.

Will be used by upcoming I8b82476f55a98f7a94d5c4f1cd80eac427b2d20f

Change-Id: I90f213d2a1be979afa024e0faa25d532f9858636
---
M library/MGCP_Templates.ttcn
1 file changed, 12 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/library/MGCP_Templates.ttcn b/library/MGCP_Templates.ttcn
index dae379e..e03fd8e 100644
--- a/library/MGCP_Templates.ttcn
+++ b/library/MGCP_Templates.ttcn
@@ -453,6 +453,17 @@
 		sdp := *
 	}
 
+	function f_mgcp_find_param_entry(MgcpParameterList pars, MgcpInfoCode code, out charstring ret)
+	return boolean {
+		for (var integer i := 0; i < sizeof(pars); i := i+1) {
+			if (pars[i].code == code) {
+				ret := pars[i].val;
+				return true;
+			}
+		}
+		return false;
+	}
+
 	function f_mgcp_find_param(MgcpMessage msg, MgcpInfoCode code, out charstring ret)
 	return boolean {
 		var MgcpParameterList pars;
@@ -461,13 +472,7 @@
 		} else {
 			pars := msg.response.params;
 		}
-		for (var integer i := 0; i < sizeof(pars); i := i+1) {
-			if (pars[i].code == code) {
-				ret := pars[i].val;
-				return true;
-			}
-		}
-		return false;
+		return f_mgcp_find_param_entry(pars, code, ret);
 	}
 
 	/* template to determine if a MGCP endpoint is a wildcard endpoint */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15963
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I90f213d2a1be979afa024e0faa25d532f9858636
Gerrit-Change-Number: 15963
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191105/cfe9df4e/attachment.htm>


More information about the gerrit-log mailing list