Change in osmo-msc[master]: add full SDP codec information to the MNCC socket

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 4 11:02:11 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15953 )

Change subject: add full SDP codec information to the MNCC socket
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

This patch is huge, I'd welcome some splitting into several patches if possible.

https://gerrit.osmocom.org/c/osmo-msc/+/15953/1/include/osmocom/msc/transaction.h 
File include/osmocom/msc/transaction.h:

https://gerrit.osmocom.org/c/osmo-msc/+/15953/1/include/osmocom/msc/transaction.h@a90 
PS1, Line 90: 	/* if true, TCH_RTP_CREATE is sent after the
Removing this seems non-related?


https://gerrit.osmocom.org/c/osmo-msc/+/15953/1/src/libmsc/gsm_04_08_cc.c 
File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/15953/1/src/libmsc/gsm_04_08_cc.c@634 
PS1, Line 634: 		trans_free(trans);
trans->callref = 0 needed here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15953
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8c3b2de53ffae4ec3a66b9dabf308c290a2c999f
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Nov 2019 11:02:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191104/1dff7c27/attachment.htm>


More information about the gerrit-log mailing list